Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected parsing cardinality restrictions #340

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Corrected parsing cardinality restrictions #340

merged 2 commits into from
Jan 3, 2022

Conversation

jesper-friis
Copy link
Collaborator

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@jesper-friis jesper-friis changed the base branch from master to flb/update-excel-parser-accroding-to-thermodynamics_example January 2, 2022 11:39
@jesper-friis jesper-friis changed the base branch from flb/update-excel-parser-accroding-to-thermodynamics_example to master January 2, 2022 11:55
francescalb
francescalb approved these changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@francescalb francescalb merged commit 0413909 into master Jan 3, 2022
@CasperWA CasperWA deleted the fix-parsing-cardinality-restrictions branch March 2, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesper-friis @francescalb @CasperWA